MBINCompiler icon indicating copy to clipboard operation
MBINCompiler copied to clipboard

Update to Extractor DONT_OVERRIDE behavior

Open HolterPhylo opened this issue 1 year ago • 3 comments

makes DONT_OVERRIDE work and processes files in DONT_OVERRIDE when GUID has changed, otherwise skip them

HolterPhylo avatar Feb 19 '24 23:02 HolterPhylo

doesn't this kind of defeat the purpose of the DONT_OVERRIDE? If the GUID changes we should notify and maybe produce the new file somewhere else I guess. but processing the file I think is maybe not exactly right since we generally will just want to patch the existing file rather than overwriting it?

monkeyman192 avatar Feb 20 '24 12:02 monkeyman192

If we just output a message or produce it elsewhere, we will still have to get to it to compare what/why the GUID changed to the existing one we have. If we leave it where it is, VS can show us just that and we can act on it more easily, I think.

Example with TkSceneNodeData.cs: image

Using: image

HolterPhylo avatar Feb 20 '24 14:02 HolterPhylo

one improvement would be to not only target the 'Toolkit' folder (which is fixed at the moment, see var 'in_dir') but instead 'NMS' folder to find the 'struct_name' location but I do not know how to do it elegantly in python :) image

HolterPhylo avatar Feb 20 '24 14:02 HolterPhylo