mongo-php-driver icon indicating copy to clipboard operation
mongo-php-driver copied to clipboard
verified publisher icon mongodb

PHPC-2093: Key Management API

Open jmikola opened this issue 3 years ago • 1 comments

https://jira.mongodb.org/browse/PHPC-2093

jmikola avatar Jul 29 '22 14:07 jmikola

@alcaeus: Feel free to review my last commit. I'll wait on https://github.com/mongodb/mongo-php-driver/pull/1347 to be merged before merging this.

One question: when merging generated arginfo.h files, I assume we always want to regenerate those after merging to ensure the "Stub hash" is consistent. Is that correct?

jmikola avatar Aug 17 '22 18:08 jmikola

One question: when merging generated arginfo.h files, I assume we always want to regenerate those after merging to ensure the "Stub hash" is consistent. Is that correct?

That is correct. Luckily, the stub hash in the arginfo file will conflict if the file was changed in both head and base branch of a PR, requiring a rebase and re-generation of the arginfo file.

alcaeus avatar Aug 18 '22 10:08 alcaeus