mongo-kafka icon indicating copy to clipboard operation
mongo-kafka copied to clipboard

Kafka 414

Open rasifmahmud opened this issue 1 year ago • 2 comments

https://jira.mongodb.org/browse/KAFKA-414

rasifmahmud avatar May 08 '24 17:05 rasifmahmud

Pardon me, I now understand that the issue is calling super.validate before we actually try to resolve the config. I think we should move the validate for both source and sink. I do not understand why we need in the evaluate function.

jagadishmdb avatar May 22 '24 23:05 jagadishmdb

Pardon me, I now understand that the issue is calling super.validate before we actually try to resolve the config. I think we should move the validate for both source and sink. I do not understand why we need in the evaluate function.

As long as we are calling super.validate on the resolved configs, we should be good.

I think there can be other ways to transform unresolved configs to resolved configs . What I proposed is just one of them. Feel free to experiment to find a better solution. Thanks

rasifmahmud avatar May 23 '24 01:05 rasifmahmud

This is added to a new pull request.

jagadishmdb avatar Jun 03 '24 16:06 jagadishmdb