chatbot icon indicating copy to clipboard operation
chatbot copied to clipboard

(DEVHUB-1898, UP-6913) Add Hotkey Functionality

Open max-melo opened this issue 1 year ago • 3 comments

Jira: https://jira.mongodb.org/browse/DEVHUB-1898, https://jira.mongodb.org/browse/UP-6913

Changes

  • Adds shouldUseHotkey prop on the ModalView and ChatWindow components that controls whether pressing the hotkey (/) will open the window, and whether the hotkey indicator is shown on the input bar.

Notes

  • Named the prop shouldUseHotkey but open to suggestions if we want to change this
  • I wasn't sure whether it made more sense to have this as a view prop, or as part of the chatbot context. I think this decision would hinge on whether we predict that the hotkey indicator will be used on an implementation that uses the InputBarTrigger, or if this is a Button trigger/ModalView-only feature. If we determine that using context makes more sense, I have a separate branch that implements it that way.

max-melo avatar Sep 17 '24 16:09 max-melo

see suggestion. also we should wait for nick to return and review before merge since he has been the primary developer on the mongodb-chatbot-ui package. he's out this week but should be back next

We have a bit of a tight deadline to get the chatbot on DevCenter/University--UAT starts next Tuesday, and I would still need to raise a couple of PRs to our repos following this one being merged. Is there a possibility that we can get this merged, and then if Nick has any suggestions when he returns I can create a follow-up PR, or something along those lines?

max-melo avatar Sep 17 '24 17:09 max-melo

see suggestion. also we should wait for nick to return and review before merge since he has been the primary developer on the mongodb-chatbot-ui package. he's out this week but should be back next

I am commenting on Max's comment on whether we can try to merge this. It would be great if someone could approve it in Nick's absence so that it can get merged. If we're concerned about cutting a release that may break someone else's experience, we could cut a release just for our project on university and developer center.

gfunk1230 avatar Sep 17 '24 17:09 gfunk1230

see suggestion. also we should wait for nick to return and review before merge since he has been the primary developer on the mongodb-chatbot-ui package. he's out this week but should be back next

We have a bit of a tight deadline to get the chatbot on DevCenter/University--UAT starts next Tuesday, and I would still need to raise a couple of PRs to our repos following this one being merged. Is there a possibility that we can get this merged, and then if Nick has any suggestions when he returns I can create a follow-up PR, or something along those lines?

I am commenting on Max's comment on whether we can try to merge this. It would be great if someone could approve it in Nick's absence so that it can get merged. If we're concerned about cutting a release that may break someone else's experience, we could cut a release just for our project on university and developer center.

given the tight deadline, let me make a pre-release that you can pull from npm. Will just make from this branch so nothing touches main branch.

mongodben avatar Sep 17 '24 18:09 mongodben

Closing in favor of https://github.com/mongodb/chatbot/pull/512 and https://github.com/mongodb/chatbot/pull/530 - thanks for the work to set this up!

nlarew avatar Oct 16 '24 15:10 nlarew