bson-rust icon indicating copy to clipboard operation
bson-rust copied to clipboard

Published 20 hours ago • verified publisher icon mongodb

RUST-1225 Add base64 string to Binary constructor

Open sanav33 opened this issue 3 years ago • 4 comments

Added a Binary constructor that accepts a base64 string instead of the bytes themselves.

sanav33 avatar Jul 05 '22 18:07 sanav33

looks like there are still some lint errors

It looks like those failures are from an unrelated PR (https://github.com/mongodb/bson-rust/pull/258). Should I go ahead and fix them anyway? @isabelatkinson

sanav33 avatar Aug 18 '22 14:08 sanav33

hmm you probably need to rebase this branch on main, it looks like #366 went in after this PR was created

isabelatkinson avatar Aug 18 '22 19:08 isabelatkinson

I might be wrong but I think I rebased before the last push to this PR and it looks like all the changes from #366 are reflected in this PR.

sanav33 avatar Aug 19 '22 00:08 sanav33

ohh I see what the issue is, chrono must've just released a new version that deprecated some constants. I needed to run cargo update to see the lint errors locally. don't worry about those in this PR, I'll make a separate one to fix.

isabelatkinson avatar Aug 19 '22 16:08 isabelatkinson

there's an unrelated clippy failure -- going to fix in a separate PR

isabelatkinson avatar Nov 29 '22 17:11 isabelatkinson