kerberos icon indicating copy to clipboard operation
kerberos copied to clipboard

fix(NODE-6320): macos runtime linking name conflict with SSL

Open nbbeeken opened this issue 1 year ago • 0 comments

Description

What is changing?

  • Put the macos build back to dynamic linking instead of runtime linking
Is there new documentation needed for these changes?

No

What is the motivation for this change?

  • On MacOS, libraries that the kerberos addon tries to load do not exist under the same names. This prevents the addon from loading.

Release Highlight

MacOS builds reverted to use dynamic linking

We recently made runtime linking with system kerberos libraries (#165) the default for Linux and MacOS (#188) platforms due to the fact that system kerberos libraries often link against the system SSL library. However, Node.js ships with it's own SSL library, and having both loaded when they are different versions would crash the addon. Inadvertently this did not work as intended on MacOS, so we're reverting the change for that platform, other platforms are unaffected.

Double check the following

  • [x] Ran npm run check:lint script
  • [x] Self-review completed using the steps outlined here
  • [x] PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • [x] Changes are covered by tests
  • [x] New TODOs have a related JIRA ticket

nbbeeken avatar Aug 09 '24 14:08 nbbeeken