compass icon indicating copy to clipboard operation
compass copied to clipboard

chore: move refresh dbs button up to be inline

Open betsybutton opened this issue 6 months ago • 4 comments

Description

Checklist

  • [ ] New tests and/or benchmarks are included
  • [ ] Documentation is changed or added
  • [ ] If this change updates the UI, screenshots/videos are added and a design review is requested
  • [x] I have signed the MongoDB Contributor License Agreement (https://www.mongodb.com/legal/contributor-agreement)
image image

Motivation and Context

  • [ ] Bugfix
  • [ ] New feature
  • [ ] Dependency update
  • [x] Misc

This change responds to lots of user feedback we're heard that the refresh button should not be buried under the ... menu.

Dependents

N/a

Types of changes

  • [ ] Backport Needed
  • [ ] Patch (non-breaking change which fixes an issue)
  • [ ] Minor (non-breaking change which adds functionality)
  • [x] Major (fix or feature that would cause existing functionality to change)

betsybutton avatar May 15 '25 22:05 betsybutton

You need either a ticket number in the title or the no-title-validation tag on the PR for the Check PR Title task to succeed, btw.

CI seems to be very red right now, probably due to https://www.electronjs.org/blog/ecosystem-node-22/

lerouxb avatar May 16 '25 10:05 lerouxb

Merged main to see if there are any actual test failures

gribnoysup avatar May 23 '25 11:05 gribnoysup

Looks like some related test failures around how we used to open the menu and click refresh to perform this action: https://github.com/mongodb-js/compass/blob/870460f23a78a4721518195d994198281098198b/packages/compass-e2e-tests/tests/instance-sidebar.test.ts#L241 @betsybutton let us know if you'd like someone else to take a look or if you're up for it!

Anemy avatar May 28 '25 18:05 Anemy

@Anemy Honestly, I don't think I'll be able to get back to this soon 😢 Any of you would probably be able to clean it up a lot faster than me. Would be great for someone to pick this up.

betsybutton avatar May 29 '25 13:05 betsybutton

Created https://github.com/mongodb-js/compass/pull/7065

Anemy avatar Jun 30 '25 17:06 Anemy