compass icon indicating copy to clipboard operation
compass copied to clipboard

chore(monorepo): Replace MongoDB 6.0.0-rc version with 6.0.0

Open gribnoysup opened this issue 3 years ago • 5 comments

Seems like rcs will be removed from the manifest based on this and this and anyway now that 6 is GA we probably want to explicitly use that in tests

gribnoysup avatar Jul 20 '22 08:07 gribnoysup

Hmm, seems like this actually broke some tests, will look more into it

gribnoysup avatar Jul 20 '22 09:07 gribnoysup

@lerouxb @gribnoysup I’ve updated the e2e tests to make use of the actual server version rather than the one gathered from the environment. The specific problem here was that we specified 6.x.x in the environment, then for version checks replaced xes with 999 and so compared 6.999.999 with 6.1.0-alpha0 for columnstore support, rather than using the actual version 6.0.0. Just generally speaking, it makes the tests a bit more self-contained in general not to rely on (potentially wrong) external information. We do runtime server version detection in mongosh as well for similar reasons.

addaleax avatar Jul 25 '22 16:07 addaleax

It is the difference between what it is running against and what it is expecting to be running against, but I suppose it doesn't matter too much. I might have been overthinking it.

lerouxb avatar Jul 25 '22 17:07 lerouxb

Okay, merged main again to see if that helps with CI, but at this point it’s just a wild guess; the e2e-coverage task is failing with segmentation faults in the mongodb-runner teardown script, although it should really not be affected at all by the version change here since it’s using 4.4.x anyway.

addaleax avatar Jul 29 '22 12:07 addaleax

Yeah, that's unexpected. Can it be something with the machine that is running tests maybe? Although this would probably not be consistently happening then, hmmmm 🤔

gribnoysup avatar Jul 29 '22 13:07 gribnoysup