typescript-runtime-type-benchmarks icon indicating copy to clipboard operation
typescript-runtime-type-benchmarks copied to clipboard

feat: add typed

Open brielov opened this issue 4 years ago • 7 comments

brielov avatar Nov 05 '21 13:11 brielov

npm ERR! cipm can only install packages when your package.json and package-lock.json or npm-shrinkwrap.json are in sync. Please update your lock file with `npm install` before continuing.
npm ERR! 
npm ERR! 
npm ERR! Missing: typed@^1.1.4
npm ERR! 

moltar avatar Nov 05 '21 15:11 moltar

@moltar I recreated package-lock.json since it was causing problems installing typed. Luckily, this happened before a massive performance improvement that wen't into typed while also saving a few bytes, so it should be included and reflected in this repo now.

brielov avatar Nov 07 '21 21:11 brielov

his happened before a massive performance improvement

That's what we like to see here 😁

Looks good, but there is a conflict in the package-lock.json file now.

moltar avatar Nov 08 '21 03:11 moltar

This is weird. GitHub still says:

This branch cannot be rebased due to conflicts

But is not giving me the reason.

screenshot-20211108T190902-L1j1Y0ss

moltar avatar Nov 08 '21 12:11 moltar

Yeah thats weird, I've pulled from master and seems to be up to date. Maybe we should open a PR on Github's own PR system? 😱

brielov avatar Nov 08 '21 12:11 brielov

Can you please try (using npm 6):

rm package-lock.json
npm i

moltar avatar Nov 09 '21 07:11 moltar

Already did that with NPM 6. After deleting package-lock.json, when I create it again git says the working tree is clean so I'm guessing the new file is the same as the one I deleted.

brielov avatar Nov 09 '21 10:11 brielov