[Enhancement] add Deno runtime in benchmark

[scarf005]

adding Deno runtime to benchmark would be useful, especially since Deno runs typescript as first class citizen.

i'm interested in opening a PR if it's acceptable. (I'd be grateful for pointers on where to work)

[kravetsone]

https://github.com/moltar/typescript-runtime-type-benchmarks/pull/1225

Now Bun runtime added so Deno will be accepted i guess

Not fan of Deno but for better runtimes comparison it would be useful!

[scarf005]

Not fan of Deno

could you elaborate?

[DarkGL]

I have started to work on deno support here https://github.com/DarkGL/typescript-runtime-type-benchmarks/pull/4

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

[scarf005]

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

@DarkGL tinkering with it right now. you can see it in https://github.com/scarf005/typescript-runtime-type-benchmarks (it's a mess) Some thoughts:

• in order to add deno, code structure may need to have wildly changed.
• in particular, start.sh, index.ts and benchmarks/main.ts may need to be changed a lot due to Deno lacking process and lacking node specific features.
• could you share issues you encountered?
• is CJS mandatory in running benchmarks? i could make Deno with ESM, not sure if it's possible with CJS
• some imports had to be replaced with esm.sh imports due to some of the modules having malformed ESM support

[DarkGL]

I had a problem running deno test inside pr.yml, but I can already see after looking at your branch that there will be many more problems to resolve

[scarf005]

I'll try to work on it tomorrow, planning to generate package.json to esm.sh mapping so imports are properly resolved to ESM.

[kravetsone]

Never worked with deno, so I have some problems to get it working, do you want to progress with it, or you can help me integrating it ?

@DarkGL tinkering with it right now. you can see it in https://github.com/scarf005/typescript-runtime-type-benchmarks (it's a mess) Some thoughts:

• in order to add deno, code structure may need to have wildly changed.
• in particular, start.sh, index.ts and benchmarks/main.ts may need to be changed a lot due to Deno lacking process and lacking node specific features.
• could you share issues you encountered?
• is CJS mandatory in running benchmarks? i could make Deno with ESM, not sure if it's possible with CJS
• some imports had to be replaced with esm.sh imports due to some of the modules having malformed ESM support

Deno moment

[DarkGL]

Btw. I think CJS was used because packages lacked support for ESM, would be nice to know which one needs CJS currently and check if they shipped new version with ESM support

[scarf005]

Deno moment

more of Node still not following browser standard moment :)

[kravetsone]

Not fan of Deno

could you elaborate?

nobody is interested in a Deno that will slowly die

also, with the 2.0 version, they will deceive many of their fans (they will remove the features of Deno)

Bun is more fine to me

It solve many problems and more faster than Deno

after many years in Deno, undici does not work on Windows...

I like that Bun is committed to drop-in replacement

It will be seen now) that a lot of changes will need to be made to support Deno

[DarkGL]

This shouldn't be a thread where we talk about deno vs bun or deno vs node.

Let's focus on integrating it.

[DarkGL]

@scarf005 with upcoming version 2 of deno do you think it will be easier to integrate?

[kravetsone]

@scarf005 with upcoming version 2 of deno do you think it will be easier to integrate?

It should be much easier because Deno abandoned his ideas

[DarkGL]

@scarf005 @kravetsone would you be willing to work on this together (with me)?

I want to progress with it, so we have node + bun + deno

[thoroc]

What are the hurdles currently on getting the benchmarks to run with Deno?

[DarkGL]

I think the biggest progress was done here, https://github.com/scarf005/typescript-runtime-type-benchmarks

But I don't know what problems @scarf005 encountered

[scarf005]

iirc there were issues in deno's node:child_process polyfill, will check again on deno 2