node-http2 icon indicating copy to clipboard operation
node-http2 copied to clipboard

Allow frames to send after the arrival of the RST_STREAM.

Open adamhenson opened this issue 9 years ago • 6 comments

Prevent exceptions for the common case in which the serving endpoint sends frames after the RST_STREAM has been sent from the client endpoint. Often frames are enqueued prior to the arrival of the RST_STREAM, but sent after. This should be expected based on HTTP/2 spec, section 6.4.

https://http2.github.io/http2-spec/#rfc.section.6.4

"However, after sending the RST_STREAM, the sending endpoint MUST be prepared to receive and process additional frames sent on the stream that might have been sent by the peer prior to the arrival of the RST_STREAM."

adamhenson avatar Jul 23 '16 04:07 adamhenson

Can confirm it's working for me too. Thanks!

Pupix avatar Nov 07 '16 11:11 Pupix

@nwgh http2 is unusably crashy, this PR fixes that. When will it be merged?

bjb568 avatar Dec 07 '16 19:12 bjb568

When will it be merged?

lujjjh avatar Mar 08 '17 02:03 lujjjh

This should be merged. It's been months.

benjamingwynn avatar Apr 27 '17 22:04 benjamingwynn

works for me too, thanks - i can push multiple resources now..

75lb avatar Jun 02 '17 22:06 75lb

merged https://github.com/kaazing/node-http2/commit/9420db76401f73372c4f6d9d9b30d5553ea313eb

hthetiot avatar Aug 23 '17 19:08 hthetiot