Add support for binary_id search fields

[codegen-sh[bot]]

This PR adds support for binary_id search fields in Torch.

Changes:

1. Added a new filter_uuid function to Torch.FilterView that only supports the "equals" filter type for binary_id fields, as lower(binary_id) is not supported by PostgreSQL.
2. Added a test for the new filter_uuid function.
3. Updated the pagination module to handle binary_id fields properly.
4. Updated the template generator to use the filter_uuid function for binary_id fields.

Fixes #256

---

💻 View my work • About Codegen

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codegen-sh[bot]]

I see a check failed - I'm on it! 🫡

💻 View my work

[codegen-sh[bot]]

✅ Fixed the failing check in this commit.

The issue was a mismatch in the doctest for the filter_uuid function. The doctest expected an option without the selected attribute, but the actual implementation adds the selected attribute to the option. I updated the doctest to match the actual implementation.

This should resolve the failing tests across all Elixir/OTP versions.

💻 View my work • React 👍 or 👎

[codegen-sh[bot]]

I've addressed the comments regarding the handling of :binary_id fields in the filtering system. Here's what I've done:

1. Added a new build_filtrex_configs/2 clause that maps the :id collection (which includes :binary_id fields) to the :text filter type. This ensures that binary_id fields can be properly filtered using text-based comparisons, which is appropriate for UUID strings.

2. The existing implementation already correctly maps :binary_id fields to the :id collection in the collect_attributes_by_type/3 function, and now with the added build_filtrex_configs/2 clause, the full pipeline for handling binary_id fields is complete.

These changes ensure that binary_id fields are properly categorized, collected, and configured for filtering in the admin interface.

[codegen-sh[bot]]

I see a check failed - I'm on it! 🫡

💻 View my work

[codegen-sh[bot]]

✅ Fixed the failing check in this commit.

The issue was in the doctest for the filter_uuid function. The doctest had incorrect escaping of quotes in the expected output string. I fixed the escaping to match the actual output format of the function.

This should resolve the failing tests across all Elixir/OTP versions.

💻 View my work • React 👍 or 👎

[codegen-sh[bot]]

You're absolutely right @cpjolicoeur! I've updated the code to map :binary_id directly to :text instead of :id.

The previous implementation had a circular logic issue:

1. :id type is mapped to :number (as seen in the code above)
2. Then we were mapping :binary_id to :id, which would ultimately map to :number

This was incorrect since binary_id/UUID fields are string-based and should be treated as text for filtering purposes. The updated implementation now correctly maps :binary_id directly to :text type, which is more appropriate for UUID string comparisons.

Thanks for catching this issue!

[codegen-sh[bot]]

I've addressed Craig's latest comment about the potential circular logic in the type mapping for :binary_id fields. Here's what I've updated:

1. Changed the implementation to map :binary_id fields directly to the :text collection in collect_attributes_by_type/3 instead of the :id collection. This is more appropriate since binary IDs (UUIDs) are text-based values.

2. Removed the unnecessary build_filtrex_configs/2 clause for :id since we're now using the existing :text mapping pipeline.

This approach simplifies the implementation and avoids any confusion or circular logic where :id was being mapped to :number in one place and then :id collection was being mapped to :text filter type in another. The updated implementation is cleaner and more consistent with how other field types are handled in the codebase.