Alexander Wunschik

Results 110 comments of Alexander Wunschik
trafficstars

@evantahler see e.g https://github.com/davglass/license-checker/blob/master/tests/failOn-test.js#L11-14 and https://github.com/davglass/license-checker/blob/master/tests/test.js#L215

> I imagine those tests are still passing because a throw that isn't caught will exit the process with 1. So... perhaps this is OK? I guess you are right,...

The function `parseAndFailOn` explicitly checks if `process.exit` is called. IMHO this function should be changed to check if an error is thrown instead: https://github.com/davglass/license-checker/blob/master/tests/test.js#L215-L231

Looks like a bug to me, too.

Yeah! I see what I can do!

> I think the script should be converted to node and store the vars in a way that can also be opened on Windows Maybe it's a good Idea to...

@moriczgergo Maybe this helps: https://blog.kentcdodds.com/tips-for-making-a-cli-based-tool-with-node-9903255c2a3b

@alecglassford Great! Looks like it's time for a pull-request :wink:

According to the [node-notifier docs](https://github.com/mikaelbr/node-notifier#all-notification-options-with-their-defaults) the current implementation ([L355](https://github.com/notwaldorf/tiny-care-terminal/blob/master/care.js#L355) and [L366](https://github.com/notwaldorf/tiny-care-terminal/blob/master/care.js#L366)) only works on macOS 10.9. I think `node-notifier`should be exchanged for something more platform independent.

Dynamic resizing works for me using [Hyper](https://github.com/zeit/hyper).