react-popper-tooltip icon indicating copy to clipboard operation
react-popper-tooltip copied to clipboard

Type check error with Typescript 4.4 exactOptionalPropertyTypes

Open gunters63 opened this issue 4 years ago • 3 comments
trafficstars

Describe the bug Applying getTooltipProps on a div gives an error with Typescript 4.4 when the (recommended) new option exactOptionalPropertyTypes is set.

To Reproduce Steps to reproduce the behavior:

  • Upgrade Typescript to 4.4.
  • Add: "exactOptionalPropertyTypes": true, to tsconfig.json
  • Style a div with {...getTooltipProps(...)}

Expected behavior No type check error

Screenshots image

Desktop (please complete the following information):

  • Windows 10
  • Newest chrome

gunters63 avatar Aug 30 '21 06:08 gunters63

i'm facing a similar issue, see #144 .

were you be able to know what was happening?

JuanJo4 avatar Nov 04 '21 20:11 JuanJo4

I had to disable the Typescript error :) Hopefully the author looks into it.

        // Todo: remove after bug is fixed: https://github.com/mohsinulhaq/react-popper-tooltip/issues/140
        // eslint-disable-next-line @typescript-eslint/ban-ts-comment
        // @ts-ignore

gunters63 avatar Nov 05 '21 02:11 gunters63

Hi, could you please check if this same happens with v4.4.0?

mohsinulhaq avatar Jun 05 '22 19:06 mohsinulhaq

@mohsinulhaq: Sorry only saw this now :) Yes, the error went away. I am using 4.4.2 now.

gunters63 avatar Oct 05 '22 09:10 gunters63

@gunters63 great, thanks!

mohsinulhaq avatar Oct 05 '22 10:10 mohsinulhaq