fb-photo-fetch icon indicating copy to clipboard operation
fb-photo-fetch copied to clipboard

Can this work with Windows?

Open froman753 opened this issue 7 years ago • 7 comments
trafficstars

I have no experience at all with javascript, but I'm looking for exactly what this program does. I've installed Node.js, but when I try running the commands from the example, I just get errors about unexpected identifier and invalid left-hand side. Is it possible for this to work in Windows?

froman753 avatar Apr 18 '18 05:04 froman753

Can you please paste the error message here?

mohsen1 avatar Apr 18 '18 16:04 mohsen1

I've since figured out that issue, I had to run npm install first. So now I've gotten the script to run, and it went through and created a folder for each of my FB albums, but now it threw some sort of error about a file already existing when it tried to start downloading them. Here is what is looks like: https://i.imgur.com/Beb81x0.png Any tips on how to fix this?

froman753 avatar Apr 18 '18 16:04 froman753

First. You're leaking your token. Make sure you invalidated that token.

We should probably do a better job when fs writing or making file names. A PR to safely write files is welcome!

mohsen1 avatar Apr 18 '18 17:04 mohsen1

Oh, I thought blurring out the first so many characters was enough to obscure it. Where was it leaked? And yea, that token had already expired when I posted this. Any insight into what the issue is with that error I'm getting?

froman753 avatar Apr 18 '18 18:04 froman753

No idea but guessing we're generating repeat names

mohsen1 avatar Apr 18 '18 20:04 mohsen1

So I believe it was an issue with the Bitmoji album causing a problem. Now after deleting that album, I've tried again and I'm getting "Maximum call stack size exceeded" error seen here: https://i.imgur.com/cmSJmLy.png

froman753 avatar Apr 18 '18 22:04 froman753

I'm trying to test only grabbing my tagged photos to see if it will work with that, but using the flag --albums=false, I'm still getting the print out of " json finished adding photos to album: " for each album. Is that just how it works without actually downloading those albums because of the flag? I'm still getting the same " Maximum call stack size exceeded error" though.

froman753 avatar Apr 20 '18 21:04 froman753