react-native-copilot icon indicating copy to clipboard operation
react-native-copilot copied to clipboard

Add verticalOffset function support #106

Open tastyqbit opened this issue 5 years ago • 5 comments

Specifically in react native navigation, the vertical offset is wrong on android (#106). This commit allows passing in an async function that can be executed at runtime to decide vertical offset based on the specific devices statusbar and topbar height (in react native navigations case, using await Navigation.constants() )

tastyqbit avatar Apr 07 '20 17:04 tastyqbit

Hey @tastyqbit , could you possibly add some explanation to the docs please?

mohebifar avatar Jun 13 '20 02:06 mohebifar

@mohebifar done :)

tastyqbit avatar Jun 16 '20 10:06 tastyqbit

LGTM, there is just some lint issues that need to be fixed before merging

mohebifar avatar Jun 18 '20 22:06 mohebifar

How can I see what the linter errors are? I can't see it in checks

tastyqbit avatar Jun 22 '20 12:06 tastyqbit

Here's the failing build:

https://travis-ci.org/github/mohebifar/react-native-copilot/builds/698862581

you can also run npm run lint locally to run the linter

mohebifar avatar Jun 25 '20 01:06 mohebifar