[stdlib] Fix `SIMD[..., u128/s128]` construction from `UInt`

[soraros]

Close #4338.

[soraros]

@JoeLoser Could you take a look at this one, since it's a bit insidious, and maybe related to Gabriel's ongoing atof work.

[JoeLoser]

!sync

[JoeLoser]

@JoeLoser Could you take a look at this one, since it's a bit insidious, and maybe related to Gabriel's ongoing atof work.

LGTM, thanks! Syncing now.

[JoeLoser]

@soraros FYI seeing failures internally like:

open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: error: 'pop.bitcast' op operand type '!pop.scalar<index>' and result type '!pop.scalar<ui64>' are cast incompatible
open-source/max/mojo/stdlib/stdlib/builtin/simd.mojo:438:36: note: called from
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: note: see current operation: %4 = "pop.bitcast"(%0) : (!pop.scalar<index>) -> !pop.scalar<ui64>
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: error: 'pop.bitcast' op operand type '!pop.scalar<index>' and result type '!pop.scalar<ui64>' are cast incompatible
open-source/max/mojo/stdlib/stdlib/builtin/simd.mojo:438:36: note: called from
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: note: see current operation: %4 = "pop.bitcast"(%0) : (!pop.scalar<index>) -> !pop.scalar<ui64>
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: error: 'pop.bitcast' op operand type '!pop.scalar<index>' and result type '!pop.scalar<ui64>' are cast incompatible
open-source/max/mojo/stdlib/stdlib/builtin/simd.mojo:438:36: note: called from
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: note: see current operation: %4 = "pop.bitcast"(%0) : (!pop.scalar<index>) -> !pop.scalar<ui64>
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: error: 'pop.bitcast' op operand type '!pop.scalar<index>' and result type '!pop.scalar<ui64>' are cast incompatible
open-source/max/mojo/stdlib/stdlib/builtin/simd.mojo:438:36: note: called from
open-source/max/mojo/stdlib/stdlib/memory/unsafe.mojo:82:6: note: see current operation: %4 = "pop.bitcast"(%0) : (!pop.scalar<index>) -> !pop.scalar<ui64>

Can you rebase this PR to see if they show up in OSS build for you as well?

[JoeLoser]

!sync

[soraros]

Is this still blocked by the Scalar[index] bug, or is it fixed internally?

[JoeLoser]

Is this still blocked by the Scalar[index] bug, or is it fixed internally?

Still blocked unfortunately as verified by internal builds failing.

[modularbot]

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the main branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

[modularbot]

Landed in a1caa58d9d33fc6d49d5a68f98a75645b1e64eb1! Thank you for your contribution 🎉