knossos icon indicating copy to clipboard operation
knossos copied to clipboard

Complete Rewrite: SvelteKit, Typescript, i18n, BEM styling

Open venashial opened this issue 3 years ago • 3 comments
trafficstars

Deploy: https://rewrite.modrinth.com

Progress: https://github.com/orgs/modrinth/projects/4

Major changes

Minor changes

  • theme switcher supports "system theme"
  • new 404 error page
  • /discord redirects to discord server
Show screenshots
image
image

venashial avatar Jan 19 '22 02:01 venashial

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
knossos ❌ Failed (Inspect) Jul 27, 2022 at 7:09AM (UTC)

vercel[bot] avatar May 19 '22 00:05 vercel[bot]

Hello! I fixed a bug where the authentication code parameter from GitHub stays in the URL query after returning to the API callback.

Here's the code:

<script lang="ts">
import { page } from '$app/stores';
import { goto } from '$app/navigation';
import { onMount } from 'svelte';

const checkCode = () => {
  if ($page.url.searchParams.get('code')) {
    $page.url.searchParams.delete('code');
    const params: string[] = [];
    $page.url.searchParams.forEach((v, k) => params.push(`${k}=${v}`));
    const url = $page.url.pathname + (params.length > 0 ? '?' : '') + params.join('&');
    goto(url);
  }
};

onMount(() => checkCode());
</script>

I am also working on this for other features in a separate repo, too.

RedstoneWizard08 avatar May 26 '22 23:05 RedstoneWizard08

Hey, that's amazing. SvelteKit & TypeScript are very fun to work with.

NatoBoram avatar Sep 16 '22 15:09 NatoBoram

Hey, that's amazing. SvelteKit & TypeScript are very fun to work with.

^^ this

RedstoneWizard08 avatar Nov 12 '22 02:11 RedstoneWizard08

Closing this since the rewrite is indefinitely on hold. We're going to go forward using Vue/Nuxt for the time being and will reevaluate at a later date whether we want to switch to Svelte. Likely won't be for quite a long time while we focus on roadmap items.

triphora avatar Dec 04 '22 03:12 triphora