importX icon indicating copy to clipboard operation
importX copied to clipboard

TV Values don't Update

Open jpdevries opened this issue 12 years ago • 7 comments
trafficstars

When set to update mode tv values do not get updated.

Steps to reproduce on a fresh MODX install with ImportX installed (assumes a tv id of 1)

  • Import a resource using:

pagetitle;alias;isfolder;tv1 Analysing;analysing;1;importxtest

  • Change importx.processor System Setting to 'update'
  • Now import (update) using:

id;pagetitle;alias;isfolder;tv1 2;Analysing2;analysing;1;importxtest2

  • Notice page title updated, but TV Value did not

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

jpdevries avatar May 10 '13 06:05 jpdevries

Been trying to track down this bug, seems like the place to look is startimport.php line 49 (where $modx->runProcessor is called for either create or update) and passes in a line element, created by csv.php

jpdevries avatar May 10 '13 07:05 jpdevries

Verified that on update the $lines Array returned by prepareCsv->prepareCsv() contains the correct updated TV Values and that what is being passed to $modx->runProcessor in startimport.php is correct (updated TV value). For some reason the update processor isn't saving those TV values

jpdevries avatar May 10 '13 07:05 jpdevries

Possibly related MODX bug: http://tracker.modx.com/issues/5965

jpdevries avatar May 10 '13 07:05 jpdevries

Any know fix/hack for this?

adamwintle avatar Oct 07 '14 16:10 adamwintle

+1. This is an important feature to be able to update tvs in bulk. Any progress or workarounds for this?

BearOutThere avatar Oct 09 '14 10:10 BearOutThere

Did the patch in #50 (i.e. v1.1.1) not do the trick? That's the only known "fix/hack" I know off, but if that doesn't work there's probably no other way to fix this other than a big refactor to stop reusing the core processors.

Mark-H avatar Oct 09 '14 18:10 Mark-H

Thanks Mark. Somehow i missed that one. Will give it a try.

All the best.

On 10/10/2014 01:36 AM, Mark Hamstra wrote:

Did the patch in #50 https://github.com/Mark-H/importX/pull/50 (i.e. v1.1.1) not do the trick? That's the only known "fix/hack" I know off, but if that doesn't work there's probably no other way to fix this other than a big refactor to stop reusing the core processors.

— Reply to this email directly or view it on GitHub https://github.com/Mark-H/importX/issues/48#issuecomment-58556255.

BearOutThere avatar Oct 09 '14 19:10 BearOutThere