web icon indicating copy to clipboard operation
web copied to clipboard

feat(test-runner-junit-reporter): Add support for flat test files to junit-reporter

Open JackRobards opened this issue 8 months ago • 1 comments

What I did

Add support for test files that do not use a describe block (aka "flat") to the junit-reporter.

A file like this would now be included in the report, where before it would not:

it('under addition', function () {
  chai.expect(1 + 1).to.equal(2);
});

it('null hypothesis', function () {
  chai.expect(true).to.be.true;
});

it('asserts error', function () {
  chai.expect(false).to.be.true;
});

As for what to call the Test Suite - I followed the same pattern that the toResultsWithMetadataByBrowserTestFileName function was using. So each of these test suites will be named based on the browser + file being tested.

This should be a non-breaking change from my testing - it is only intended to detect some test cases that wouldn't be included previously!

closes #2901

JackRobards avatar Mar 07 '25 19:03 JackRobards

🦋 Changeset detected

Latest commit: 6d6ee2bfe9a4e8ed10949bea9fd687644f571c62

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@web/test-runner-junit-reporter Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Mar 07 '25 19:03 changeset-bot[bot]

@bashmish Is this something you would have time to take a look at, or are there any changes I should make here? I totally get it if you're just busy with other things, but I wanted to check-in in case there's anything I can do here.

JackRobards avatar Aug 21 '25 20:08 JackRobards