registry icon indicating copy to clipboard operation
registry copied to clipboard

fix: resolve registry image conflict in docker-compose

Open 8806667653 opened this issue 5 months ago • 2 comments
trafficstars

Issue: links directive was failing on podman

  • Removed unsupported 'links' directive for Podman compatibility

It was failing on Podman because Podman doesn't support the links directive that Docker Compose does, and we already using depends_on, which establishes the dependency relationship between services; we can simply remove the links section from your docker-compose.yml file.

Motivation and Context

docker-compose -links deprecated #107 Fix the defect by removing link.

How Has This Been Tested?

Yes. Test by running on both. For Docker run. docker build -t registry . docker compose up

For Podman podman build -t registry . podman compose up

Breaking Changes

Yes for podman.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [ x] Breaking change (fix or feature that would cause existing functionality to change)
  • [ ] Documentation update

Checklist

  • [x ] I have read the MCP Documentation
  • [ x] My code follows the repository's style guidelines
  • [ x] New and existing tests pass locally
  • [ x] I have added appropriate error handling
  • [x ] I have added or updated documentation as needed

Additional context

It is related to issue #107

8806667653 avatar Jun 01 '25 07:06 8806667653

Please merge this or i do need to do anything else for merging.

8806667653 avatar Jun 08 '25 06:06 8806667653

Hi @toby , review complete, merge please 🙏 !

yshngg avatar Jun 09 '25 10:06 yshngg

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests.

:loudspeaker: Thoughts on this report? Let us know!

codecov-commenter avatar Aug 06 '25 10:08 codecov-commenter