modal-client icon indicating copy to clipboard operation
modal-client copied to clipboard

Published 20 hours ago • verified publisher icon modal-labs

Deprecate unused memory snapshot field

Open luiscape opened this issue 1 year ago • 5 comments

Deprecates the unused field is_checkpointing_function.

luiscape avatar May 30 '24 15:05 luiscape

Don't we call this snapshot now? Or has that not propagated everywhere?

mwaskom avatar May 30 '24 16:05 mwaskom

We call it memory snapshots now but internally the fields are still called "checkpoint".

luiscape avatar May 30 '24 16:05 luiscape

@luiscape any reason we haven't merged this? (Looks like it's accrued a merge conflict unfortunately).

mwaskom avatar Jun 11 '24 20:06 mwaskom

I want this to land first.

luiscape avatar Jun 12 '24 14:06 luiscape

Sounds good!

mwaskom avatar Jun 12 '24 14:06 mwaskom