mockito-kotlin icon indicating copy to clipboard operation
mockito-kotlin copied to clipboard

Published 20 hours ago • verified publisher icon mockito

migrate to JUnit5

Open hennr opened this issue 4 years ago • 5 comments
trafficstars

Not sure if you want to, but why not migrate to JUnit 5 I thought :)

hennr avatar Mar 23 '21 13:03 hennr

Ideally I would like to do this when we switch over the main Mockito test suite (https://github.com/mockito/mockito/issues/1246) and I don't think we want to move to JUnit 5 just yet. Let's discuss further in the Mockito issue before we merge any PRs related to JUnit 5.

TimvdLippe avatar Mar 23 '21 14:03 TimvdLippe

All right, no worries. If you need a helping hand on the other test code, let me know.

hennr avatar Mar 23 '21 14:03 hennr

@hennr Just curious. What are the advantages of using junit5 over junit4 (with respect to an updated junit dependency like junit 4.13.2)?

bohsen avatar Mar 23 '21 14:03 bohsen

@bohsen That would be the same question for me, but let's move that discussion to the Mockito issue rather than this PR, so that we can keep this PR focused on the implementation. Thanks!

TimvdLippe avatar Mar 23 '21 15:03 TimvdLippe