react-resizable-rotatable-draggable icon indicating copy to clipboard operation
react-resizable-rotatable-draggable copied to clipboard

Consider removing dependency to styled-components

Open TomiS opened this issue 6 years ago • 1 comments
trafficstars

While styled-components is great, I would like to argue that library like this would be much better off just by manipulating inline styles directly.

Reasoning:

  • There are many css-in-js libs and styled-components is just one of them. The majority of the potential user base cannot use this library because of this dependency. Basically just people who already use styled-components are willing to accept this as dependency.
  • Styled-components seems to add quite little value in this context as you basically just need to manipulate the size and shape of the object (as far as I understand). No reason why this couldn't be done inline.

Of course I can always fork and remove the dependency for myself, but I just wanted to put this here in case this was not very intentional choice.

ps. Otherwise the lib seems really nice and it solves exactly the issue I'm facing right now.

TomiS avatar Jan 16 '19 13:01 TomiS

Yeah great library. Super lightweight and flexible!

I agree, the reliance on styled-components doesn't provide much to the library verse the size of the package :)

stwilz avatar Jan 23 '19 23:01 stwilz