mocha-chai-jest-snapshot icon indicating copy to clipboard operation
mocha-chai-jest-snapshot copied to clipboard

latest version of mocha-chai-jest-snapshot is not compatible with chai@"^5.0.0"

Open MoonOKC opened this issue 1 year ago • 5 comments

Will there be any release to catch up chai@"^5.0.0" as I can not update my chai with : npm WARN Could not resolve dependency: npm WARN peer chai@"^4.3.6" from [email protected]

MoonOKC avatar Jan 16 '24 15:01 MoonOKC

Same problem here.

piranna avatar May 05 '24 09:05 piranna

Same here

blephy avatar Jul 19 '24 07:07 blephy

This appears to be the best snapshotting lib for mocha/chai. At which point do we fork this and continue maintaining?

tpluscode avatar Aug 22 '24 06:08 tpluscode

Sorry for the delayed response. I was on a long trip. I’ll check on it.

mochiya98 avatar Aug 23 '24 13:08 mochiya98

I’ve realized that there are various heavy obstacles to supporting ESModules. I give up to support it. sorry. Contribution are always welcome.

mochiya98 avatar Aug 23 '24 22:08 mochiya98

I looked at your setup and indeed, the integration tests would be a challenge to rework to support ESM

That said, it should not be necessary to convert the entire package to ESM in order to work with chai v5. Not even a peer dependency on chai is necessary after applying a small change.

PR: https://github.com/mochiya98/mocha-chai-jest-snapshot/pull/21

tpluscode avatar Aug 28 '24 10:08 tpluscode

Good idea! I'll check it out...

mochiya98 avatar Aug 29 '24 23:08 mochiya98

fixed in 1.1.6 (thanks @tpluscode !)

mochiya98 avatar Sep 01 '24 15:09 mochiya98