swarmkit icon indicating copy to clipboard operation
swarmkit copied to clipboard

Support Go Modules

Open SamWhited opened this issue 6 years ago • 2 comments
trafficstars

Experiment with modules support.

Note that if you run go mod vendor with Go 1.13 the vendor validation will be broken because they've changed the vendoring / go.mod rules (again). Future PRs will need to use Go 1.12, or we can bump tests to run with Go 1.13 and require that everyone use that. Hopefully these rules will stabilize soon.

SamWhited avatar Sep 18 '19 20:09 SamWhited

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "support_modules" [email protected]:SamWhited/swarmkit.git somewhere
$ cd somewhere
$ git commit --amend -s --no-edit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Sep 18 '19 20:09 GordonTheTurtle

Codecov Report

Merging #2895 into master will increase coverage by 2.19%. The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2895      +/-   ##
==========================================
+ Coverage   61.58%   63.78%   +2.19%     
==========================================
  Files         139        3     -136     
  Lines       22616      439   -22177     
==========================================
- Hits        13928      280   -13648     
+ Misses       7207      107    -7100     
+ Partials     1481       52    -1429

codecov[bot] avatar Sep 18 '19 21:09 codecov[bot]

This has been done in https://github.com/moby/swarmkit/pull/3061 (thanks for kicking of the work @SamWhited - hope you're doing well!)

thaJeztah avatar Dec 15 '22 16:12 thaJeztah