swarmkit icon indicating copy to clipboard operation
swarmkit copied to clipboard

Fix some typos in comment

Open JoeWrightss opened this issue 6 years ago • 3 comments
trafficstars

  1. "impelemented" to "implemented" in line 46.
  2. "nework" to "network" in line 498.

JoeWrightss avatar Jan 19 '19 17:01 JoeWrightss

Please sign your commits following these rules: https://github.com/moby/moby/blob/master/CONTRIBUTING.md#sign-your-work The easiest way to do this is to amend the last commit:

$ git clone -b "patch-3" [email protected]:JoeWrightss/swarmkit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842354612160
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -f

Amending updates the existing PR. You DO NOT need to open a new one.

GordonTheTurtle avatar Feb 01 '19 15:02 GordonTheTurtle

Thank you for guiding me. I signed it @GordonTheTurtle .🐯

JoeWrightss avatar Feb 01 '19 15:02 JoeWrightss

Codecov Report

Merging #2809 into master will decrease coverage by 0.09%. The diff coverage is 61.76%.

@@            Coverage Diff            @@
##           master    #2809     +/-   ##
=========================================
- Coverage   61.93%   61.83%   -0.1%     
=========================================
  Files         137      137             
  Lines       22126    22107     -19     
=========================================
- Hits        13703    13670     -33     
- Misses       6940     6968     +28     
+ Partials     1483     1469     -14

codecov[bot] avatar Feb 01 '19 16:02 codecov[bot]

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@0da442b). Click here to learn what that means. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #2809   +/-   ##
=========================================
  Coverage          ?   62.14%           
=========================================
  Files             ?      153           
  Lines             ?    24177           
  Branches          ?        0           
=========================================
  Hits              ?    15026           
  Misses            ?     7600           
  Partials          ?     1551           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

codecov-commenter avatar Dec 15 '22 17:12 codecov-commenter