mobx.dart icon indicating copy to clipboard operation
mobx.dart copied to clipboard

Allow a custom equals parameter for observable collections

Open amondnet opened this issue 1 year ago • 2 comments

Describe the changes proposed in this Pull Request.

Allow a custom equals parameter for observable collections, like observable stream, observable and computed .

https://github.com/mobxjs/mobx.dart/pull/771 https://github.com/mobxjs/mobx.dart/pull/482

If the PR fixes a specific issue, reference the issue with Fixes #.


Pull Request Checklist

  • [ ] If the changes are being made to code, ensure the version in pubspec.yaml is updated.
  • [ ] Increment the major/minor/patch/patch-count, depending on the complexity of change
  • [ ] Add the necessary unit tests to ensure the coverage does not drop
  • [ ] Update the Changelog to include all changes made in this PR, organized by version
  • [ ] Run the melos run set_version command from the root directory
  • [ ] Include the necessary reviewers for the PR
  • [ ] Update the docs if there are any API changes or additions to functionality

amondnet avatar Dec 15 '23 09:12 amondnet

Deploy request for mobx pending review.

Visit the deploys page to approve it

Name Link
Latest commit d13d88d4e59d6313ab56c11dc10523aace309789

netlify[bot] avatar Dec 15 '23 09:12 netlify[bot]

Codecov Report

Merging #970 (d13d88d) into main (d14a27e) will decrease coverage by 0.62%. Report is 3 commits behind head on main. The diff coverage is 83.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #970      +/-   ##
==========================================
- Coverage   99.00%   98.38%   -0.62%     
==========================================
  Files          57       57              
  Lines        2005     2043      +38     
==========================================
+ Hits         1985     2010      +25     
- Misses         20       33      +13     
Flag Coverage Δ
flutter_mobx 100.00% <ø> (ø)
mobx 97.69% <83.33%> (-0.88%) :arrow_down:
mobx_codegen 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rc/api/observable_collections/observable_list.dart 99.20% <90.00%> (-0.80%) :arrow_down:
...src/api/observable_collections/observable_map.dart 98.41% <89.47%> (-1.59%) :arrow_down:
...src/api/observable_collections/observable_set.dart 91.17% <76.92%> (-8.83%) :arrow_down:

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d14a27e...d13d88d. Read the comment docs.

codecov[bot] avatar Dec 15 '23 09:12 codecov[bot]