mobx-state-tree icon indicating copy to clipboard operation
mobx-state-tree copied to clipboard

Published 20 hours ago • verified publisher icon mobxjs

fix up snapshot applying to maybeNull Array union

Open willrax opened this issue 4 years ago • 1 comments

Adds a failing test for issue #1648

Next steps are to figure out whats up. I don't think this is a great test but it fails in the right way for now. We'll improve it as we figure out exactly whats broken here.

Might not even be the right place to add the test!

willrax avatar Jan 21 '21 20:01 willrax

Good call. Now we need a PR to fix the failing test!

jamonholmgren avatar Mar 20 '21 16:03 jamonholmgren

Hey @willrax - are you still interested in bringing this MST PR to conclusion? If so, I'm happy to help you get CI passing. If not, let us know and we can perhaps find a way to take this to the finish line.

Really appreciate your initial effort here, once way or another!

coolsoftwaretyler avatar Jun 28 '23 04:06 coolsoftwaretyler

Hey @willrax - thanks again for putting together this PR. It's a useful step towards resolving the issue, but I'm trying to clean up and close out some stale PRs, so I'm going to close this for now.

I've added this PR to the issue for posterity, so folks will have a good starting point if anyone wants to pick it up.

coolsoftwaretyler avatar Sep 21 '23 16:09 coolsoftwaretyler