ocpp icon indicating copy to clipboard operation
ocpp copied to clipboard

OCPP 2.0 Enums and helper methods

Open tropxy opened this issue 6 years ago • 5 comments

tropxy avatar Nov 07 '19 04:11 tropxy

DeepCode's analysis on #70d2c7 found:

  • :x: 0 critical issues. :warning: 0 warnings and 0 minor issues. :heavy_check_mark: 0 issues were fixed.

:speech_balloon: This comment has been generated by the DeepCode bot, installed by the owner of the repository. The DeepCode bot protects your repository by detecting and commenting on security vulnerabilities or other critical issues.


:relaxed: If you want to provide feedback on our bot, here is how to contact us.

ghost avatar Nov 07 '19 04:11 ghost

Yes, my intention was just to start discussing it with something. I am aware this is not enough, but we have to start from somewhere

tropxy avatar Nov 07 '19 08:11 tropxy

related to #61

lsaavedr avatar Mar 08 '20 23:03 lsaavedr

Why subclassing from Enum is not needed (I need it in my django backend), using getattr is not a good practice 😭, Enum was proposal for this!

lsaavedr avatar Mar 08 '20 23:03 lsaavedr

@lsaavedr I commented in #61 to keep discussion in one 1 place.

OrangeTux avatar Mar 16 '20 08:03 OrangeTux

Due to the age and that 2.1 is to be used in place of 2.0, I'll close this PR

Jared-Newell-Mobility avatar Oct 04 '23 11:10 Jared-Newell-Mobility