mne-qt-browser icon indicating copy to clipboard operation
mne-qt-browser copied to clipboard

Enhance Help Menu for Better Functionality Discoverability

Open mohitkumhar opened this issue 9 months ago • 7 comments

Reference issue

Example: Fixes #84

What does this fix?

This PR improves the Help menu by replacing the old HelpDialog with a simpler and more accessible menu. Now, users can find keyboard and mouse shortcuts directly in a dropdown menu instead of a separate dialog.

Key changes

  • Removed the HelpDialog class.
  • Introduced a Help button (QToolButton) for quick access.

Additional information

Please review the changes and let me know if there are any improvements or issues that need to be addressed.

Here are the screenshots of the UI

image

image

mohitkumhar avatar Feb 25 '25 18:02 mohitkumhar

@mohitkumhar I think what @hoechenberger had in mind was a top-level menu like that in https://github.com/mne-tools/mne-qt-browser/pull/126. It looks like you added a menu that is accessed via a toolbar button instead

larsoner avatar Mar 05 '25 16:03 larsoner

Hey @larsoner , Kindly check this UI , is it the expected output?

Image

Image

mohitkumhar avatar Mar 07 '25 12:03 mohitkumhar

@mohitkumhar Thanks for your work on this!

What I actually had in mind was adding a full menu bar, though. Something like what you'd see in other applications like e.g. MS Word:

Screenshot 2025-03-07 at 13 23 00

Since menu items can be linked to keyboard shortcuts (which will be displayed in the menu itself), these would be kind of self-documenting.

hoechenberger avatar Mar 07 '25 12:03 hoechenberger

Sure @hoechenberger I understand it, let me create menu and share sample

mohitkumhar avatar Mar 08 '25 20:03 mohitkumhar

You can take #126 as a starting point

hoechenberger avatar Mar 08 '25 20:03 hoechenberger

Hey @hoechenberger , Kindly check it out!

https://github.com/user-attachments/assets/e8451c65-37ec-4e9b-b21b-f8c6f8149135

mohitkumhar avatar Mar 12 '25 19:03 mohitkumhar

Hey , kindly check the commit I made

mohitkumhar avatar Mar 31 '25 17:03 mohitkumhar