mne-qt-browser icon indicating copy to clipboard operation
mne-qt-browser copied to clipboard

Published 20 hours ago • verified publisher icon mne-tools

BUG: Fix bug with over-updating and antialias toggle

Open larsoner opened this issue 1 year ago • 1 comments

In finding #270 I noticed that just opening the Settings dialog triggered 3 updates. There is no reason this is necessary, and is an unnecessary slowdown. It happens because we connect the listener then set the value (to it's currently used value)... which triggers an update.

And this is a bug for antialiasing actually because it triggers an AA toggle, so if you had AA on, it connected the listener, set the setChecked(True) which initiated a toggle, disabling AA. So the check state was always out of phase with the actual state.

larsoner avatar Jul 10 '24 16:07 larsoner

@nmarkowitz feel free to take a look and click "approve" if you're happy and I'll merge

larsoner avatar Jul 10 '24 16:07 larsoner

This is a pretty trivial change so marking for merge-when-green after merging main into this branch

larsoner avatar Sep 13 '24 14:09 larsoner