mne-qt-browser
mne-qt-browser copied to clipboard
mne-tools
ENH: Rework OverviewBar
Description
Following discussions in #20, the current OverviewBar-modes should be reworked.
Ideas
- [ ] Move "channels"-mode into a thin line next to the vertical scrollbar
- [x] Add mode with no background
- [ ] Add time underneath
- [ ] Make vertically resizable
- [ ] Improve performance
Regarding the Minimap (which would just zscore now if we moved channels-mode away) it might be hard to identify the markers for events, annotations and bad channels with the fidgety background.
"channels"-mode
"zscore"-mode
To see those markers, channels-mode or no background at all are probably better. Maybe instead of removing "channels"-mode completely, we add a third option for no background. And the thin line next to the vertical scrollbar will be implemented additionally.
Further ideas?
Do you have further ideas on how to use the background of the OverviewBar/Minimap? (e.g. additional statistical metrics?)
Ohhhh so there is information in the "channels" mode, namely the event markers (and maybe annotations?). In that case maybe we should hide it when there are no annotations or event markers only... not sure.
Ohhhh so there is information in the "channels" mode, namely the event markers (and maybe annotations?). In that case maybe we should hide it when there are no annotations or event markers only... not sure.
No, the markers are independently drawn from the "channels" or "zscore" background. I was just thinking when "zscore" will be the only background available without "channels", that would make the markers hard to read.
No, the markers are independently drawn from the "channels" or "zscore" background.
My point is more that I was wrong above when I said that there wouldn't be any horizontal information in channels mode. There is -- namely the markers (if present). So maybe instead of deciding if we should show the bottom bar based on whether in channels or zscore mode (as I suggested before), we should only hide the bottom bar if in channels mode and there are no markers to show
I think it's worth saying that for all-EEG data it's a bit weird to have a big black box down there. Even if there are some annotations showing, it seems a bit odd to put them on a black background. Which I think is another vote for having color-that-indicates-channel-type being a thin rectangle along the vertical scrollbar, and not having it in that overview box.
I understand. The users can toggle the OverviewBar with pressing "o" if it takes too much space for them.
I think it's worth saying that for all-EEG data it's a bit weird to have a big black box down there. Even if there are some annotations showing, it seems a bit odd to put them on a black background.
So in this case you could just as well have no background, right?
Which I think is another vote for having color-that-indicates-channel-type being a thin rectangle along the vertical scrollbar, and not having it in that overview box.
I am also +1 on that, this thin vertical indicator would also still enable a bit of overview when the OverviewBar is toggled off.
So in this case you could just as well have no background, right?
yes, and further I think that even in cases with multiple channel types, there should be no background (because that info will be available in the new thin rectangle)
- I like the idea of displaying channel type information in the vertical scrollbar
- I would like having a "no background" (white/transparent) overview-mode which just shows the annotations ... so pretty much like the "channels" overview mode for all-EEG channels now, but only that it's not black but white for better visibility
- I remember using the FieldTrip
ft_rejectvisualfunction some years ago and liked it ... perhaps studying that will also show a few nice options for the overview mode statistics: https://www.fieldtriptoolbox.org/tutorial/visual_artifact_rejection/
I try to implement some of this before 0.2-release, probably won't manage everything
