Marija Najdova

Results 338 comments of Marija Najdova

> I think the use of usePreviousProps is incorrect, as badgeContent, max and displayValue shouldn't be coupled with the invisible value. They should always be updated regardless. It was originally...

Thanks for looking into this Romain. The improvements is too big for us to not look into it. As mentioned before, we are likely going to have Emotion for a...

> For the first step (in v6.x), I prefer to keep all of the exported utilities to behave the same (the tests should not change) so that it's not a...

> we added the nonce-value to the cache on CreateEmotionCache.tsx: > > it works with most of the components and all sx's but we have found that some components including...

Are you importing stuff directly from this file? I am asking because that is not supported. We allow imports up to level3, for e.g. `@mui/material/styles`. All imports which are valid...

The general direction of the PR makes sense to me, but I wouldn't want to be the reviewer, as I am not fully aware of the scope and usage of...

@Mike-Ro what do you mean with classic components? Do you mean supporting Pigment CSS in Material UI? If this is the case, you can follow the https://mui.com/material-ui/migration/migrating-to-pigment-css/ guide to enable...

Your config looks correct (you should have the transformLibraries: ['@mui/material'],). Can you try moving the css call outside of the render function for the page, e.g. like this: ```diff import...

Looks like the Button component still uses emotion although I added the `transformLibraries: ['@mui/material'],` with the default Mateiral UI theme. It seems to be something with the next.js plugin, as...

I meant the next.js plugin sorry, let me edit the comment! Your setup seems good, the same setup works in vite (using vite's plugin), so I assume is something related...