Marija Najdova
Marija Najdova
> MUI X DataGrid went with the same solution though. Ref: https://github.com/mui/mui-x/pull/8744 > Should we proceed with merging the PR? @mnajdova Approved, @hbjORbj left just one comment for clarifying the...
Can't you do this - https://codesandbox.io/s/keen-dewdney-61hxsk ? I don't understand what is the issue.
We decided to remove the logic around hover, focus and active state from both hooks, and see what we end up with. Based on that we can decide what's going...
@colmtuite I am closing this PR, I don't have a bandwidth to push it forward. The last discussion we had regarding this was to remove the logic for the pseudo-elements...
> @mnajdova do you see any reason not to go forward with this change? Is there any historical context of why the Chip losing focus with the escape key behavior...
The error is self-descriptive, what you are providing is not a valid color. Which version did this work with? I tried an older version (before v.15.13), and it still yields...
Thanks for the report. We have a section on supported browser and node version: https://mui.com/material-ui/migration/migration-v4/#supported-browsers-and-node-versions. Do you think we should move this to another section to make it clearer?
Hey @m4theushw, nice to see a familiar face :) > If it's a bug, I think it's just the case of aligning the buttons with justify-content: flex-end instead of flex-direction:...
[material-ui][FocusTrap] getTabbable function has a return type of string[] instead of HTMLElement[]
Nice catch, would you like to introduce a PR with the change?
> I can't reproduce it in a sandbox. We can't rely do anything without reproduction. Try creating a repository if you can't do it on codesandbox.