pihole-regex
pihole-regex copied to clipboard
Allow for multiple docker instances matching 'pihole'
I run two pihole docker instances. The install script fails in this case because docker ps --filter name=pihole can match and return multiple lines. This patch does the right thing in that case: namely, applies the regex update to all of the running instances.
Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines. Sorry about that.
Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines.
@jdelkins Just happened to stumble across this PR -- for future reference, you can ignore whitespace changes in GitHub diffs. See https://github.com/mmotti/pihole-regex/pull/54/files?w=1
Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines.
@jdelkins Just happened to stumble across this PR -- for future reference, you can ignore whitespace changes in GitHub diffs. See #54 (files)
Thanks! I knew that's easy with git diff -w but nice to know it's also easy on github.