pihole-regex icon indicating copy to clipboard operation
pihole-regex copied to clipboard

Allow for multiple docker instances matching 'pihole'

Open jdelkins opened this issue 4 years ago • 3 comments

I run two pihole docker instances. The install script fails in this case because docker ps --filter name=pihole can match and return multiple lines. This patch does the right thing in that case: namely, applies the regex update to all of the running instances.

jdelkins avatar Oct 26 '21 21:10 jdelkins

Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines. Sorry about that.

jdelkins avatar Oct 26 '21 21:10 jdelkins

Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines.

@jdelkins Just happened to stumble across this PR -- for future reference, you can ignore whitespace changes in GitHub diffs. See https://github.com/mmotti/pihole-regex/pull/54/files?w=1

ragibson avatar Nov 23 '21 19:11 ragibson

Note the diff looks extensive but it's really not. I had to put the core of the logic inside of a function, which creates an extra indent for a lot of lines.

@jdelkins Just happened to stumble across this PR -- for future reference, you can ignore whitespace changes in GitHub diffs. See #54 (files)

Thanks! I knew that's easy with git diff -w but nice to know it's also easy on github.

jdelkins avatar Nov 24 '21 01:11 jdelkins