Misagh Moayyed

Results 70 comments of Misagh Moayyed

You can let that go, but your patch still need to carry proper unit tests.

Thank you, that is good enough for now. Please cross check with CI builds and go through the failures, and fix the stuff that might be relevant. I see some...

Thank you @rbonatuvic. There are a few style violations. Can you please review those?

One point to raise here is that in the event that the principal and surrogate exist in the same ldap search trees, this will incur a performance cost, right?

In other words, assuming the performance cost is something of a concern, one possible idea would be to search the immediate connection factory first, and if that fails, then look...

Sounds good, thank you. Let's keep this WIP until then.

The PR is merged with some small modifications: 1. The header is renamed to X-SessionId, and it's only optionally passed when a session is in fact available. 2. At the...

If it helps, here is a stacktrace even without a custom `@RestControllerAdvice`: ``` Caused by: java.lang.NoSuchMethodError: 'void org.springframework.web.method.ControllerAdviceBean.(java.lang.Object)' at org.springdoc.core.service.GenericResponseService.lambda$getGenericMapResponse$8(GenericResponseService.java:706) at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:178) at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024) at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:575)...

@leleuj I think we have given this enough time, and with no feedback, I'd say we should proceed. Before we do, do you think you could modify a puppeteer test...

Can you please explain how your puppeteer test scenario tests the fact that backchannel logout did indeed happen and the user was logged out?