minimal-mistakes icon indicating copy to clipboard operation
minimal-mistakes copied to clipboard

GitHub Workflows security hardening

Open sashashura opened this issue 3 years ago • 5 comments
trafficstars

This PR adds explicit permissions section to workflows. This is a security best practice because by default workflows run with extended set of permissions (except from on: pull_request from external forks). By specifying any permission explicitly all others are set to none. By using the principle of least privilege the damage a compromised workflow can do (because of an injection or compromised third party tool or action) is restricted. It is recommended to have most strict permissions on the top level and grant write permissions on job level case by case.

sashashura avatar Sep 01 '22 16:09 sashashura

Please let me know if you have any questions.

sashashura avatar Sep 20 '22 07:09 sashashura

@iBug @mmistakes could you please review it?

sashashura avatar Dec 01 '22 01:12 sashashura

An example of a recent workflow run with unrestricted permissions: image

sashashura avatar Dec 01 '22 01:12 sashashura

This looks good to me, but I'm afraid @mmistakes isn't going to respond anytime soon. I haven't seen him online for a few months, and I don't have the access to merge this.

iBug avatar Dec 01 '22 09:12 iBug

Thanks for letting me know. I hope he's ok!

sashashura avatar Dec 01 '22 10:12 sashashura