mlr3filters icon indicating copy to clipboard operation
mlr3filters copied to clipboard

importance filter default is bad

Open mb706 opened this issue 2 years ago • 3 comments

the importance filter by default uses the "featureless" learner by default, which makes the filter basically useless. There are likely very few cases in which the user wants to initialize the importance filter with the featureless learner. Therefore, the learner should not have a default; when constructing the importance filter without providing a learner, an error should be thrown instead.

mb706 avatar May 22 '23 01:05 mb706

I agree: https://github.com/mlr-org/mlr3filters/issues/130

sebffischer avatar Jun 30 '23 09:06 sebffischer

I think these choices were made to make the as.data.table() conversion work. Maybe we should implement your solution from mlr3pipelines in mlr3misc.

sebffischer avatar Jun 30 '23 09:06 sebffischer

https://github.com/mlr-org/mlr3misc/pull/92 would help for the dict -> dt conversion

sebffischer avatar Oct 30 '23 07:10 sebffischer