mobile_app_open icon indicating copy to clipboard operation
mobile_app_open copied to clipboard

chore: increase Android minSdkVersion from 21 to 30

Open anhappdev opened this issue 1 year ago • 11 comments

  • Closes #858

anhappdev avatar Feb 27 '24 06:02 anhappdev

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

github-actions[bot] avatar Feb 27 '24 06:02 github-actions[bot]

@mohitmundhragithub Can you please help fix the crash on QTI backend:

02-26 23:36:30.204: F/native(26913): cpp/backend_qti/qti_backend_helper.cc:123 runtime 0 is not available on this platform

anhappdev avatar Feb 27 '24 08:02 anhappdev

@mohitmundhragithub Can you please help fix the crash on QTI backend:

02-26 23:36:30.204: F/native(26913): cpp/backend_qti/qti_backend_helper.cc:123 runtime 0 is not available on this platform

I seem to not have permission to view the log files. Can you please help share it?

mohitmundhragithub avatar Feb 28 '24 09:02 mohitmundhragithub

I seem to not have permission to view the log files. Can you please help share it?

Yes. log.txt

anhappdev avatar Feb 28 '24 10:02 anhappdev

I see this error is causing the test case to fail:

02-26 23:36:30.139: E/audit(1298): type=1400 audit(1709019390.134:12783): avc: denied { read } for pid=26913 comm="DartWorker" name="adsprpc-smd-secure" dev="tmpfs" ino=1396 scontext=u:r:untrusted_app:s0:c78,c257,c512,c768 tcontext=u:object_r:vendor_xdsp_device:s0 tclass=chr_file permissive=0 SEPF_SM-S908U1_12_0001 audit_filtered

MLPerf is considered an untrusted app without some play store key. Seems like with minSDKVersion set to 30, it doesn't allow to read few of the libraries on the devices, for untrusted app.

Can you please share the device's android version? I can check internally to find a workaround for this. Also, is the device on the latest update already?

mohitmundhragithub avatar Feb 28 '24 17:02 mohitmundhragithub

I see this error is causing the test case to fail:

02-26 23:36:30.139: E/audit(1298): type=1400 audit(1709019390.134:12783): avc: denied { read } for pid=26913 comm="DartWorker" name="adsprpc-smd-secure" dev="tmpfs" ino=1396 scontext=u:r:untrusted_app:s0:c78,c257,c512,c768 tcontext=u:object_r:vendor_xdsp_device:s0 tclass=chr_file permissive=0 SEPF_SM-S908U1_12_0001 audit_filtered

MLPerf is considered an untrusted app without some play store key. Seems like with minSDKVersion set to 30, it doesn't allow to read few of the libraries on the devices, for untrusted app.

Can you please share the device's android version? I can check internally to find a workaround for this. Also, is the device on the latest update already?

this could be a plausible reason for it: https://developer.android.com/about/versions/10/behavior-changes-10#execute-permission

mohitmundhragithub avatar Feb 28 '24 17:02 mohitmundhragithub

The test device was a Galaxy S22 Ultra, API Level 33

Screenshot 2024-02-29 at 10 46 01

anhappdev avatar Feb 29 '24 03:02 anhappdev

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

sonarqubecloud[bot] avatar Jun 13 '24 03:06 sonarqubecloud[bot]

packing .so file in some other ways? suggestion by @mohitmundhragithub

freedomtan avatar Aug 20 '24 05:08 freedomtan

@RSMNYS to check if we can find any other way to pack .so file

freedomtan avatar Aug 20 '24 05:08 freedomtan

@RSMNYS to check if we can find any other way to pack .so file

@freedomtan I checked the GeekbenchAI apk internally. The way they are packing the libs is exactly similar to how we are packing it in the mlperf app.

mohitmundhragithub avatar Aug 20 '24 16:08 mohitmundhragithub