mobile_app_open icon indicating copy to clipboard operation
mobile_app_open copied to clipboard

User can abort a running benchmark

Open anhappdev opened this issue 2 years ago • 2 comments

With https://github.com/mlcommons/mobile_app_open/pull/718 a long-running benchmark will be aborted after 10 minutes. But it doesn't work for the Offline scenario (see discussion at https://github.com/mlcommons/inference/issues/1397).

Another way to stop a running benchmark is to use:

/// \brief Aborts the running test.
/// \details This function will stop issueing new samples to the SUT. StartTest
/// will return after the current inference finishes. Since StartTest is a
/// blocking function, this function can only be called in another thread.
void AbortTest();

https://github.com/mlcommons/inference/blob/da9b4d54bd2bd2ae26316f75987d71103122e3ca/loadgen/loadgen.h#L79-L83

The app should have a button in the progress screen so that users can abort the running benchmark.

anhappdev avatar Jul 10 '23 05:07 anhappdev

In my testing, AbortTest() did not work as expected. When calling AbortTest(), the app just hangs forever and StartTest() never finished.

The issue was discussed in https://github.com/mlcommons/mobile_app/issues/289, but there was no solution.

For reference, here is the branch with AbortTest() implemented: 749/abort-running-benchmark

anhappdev avatar Jul 23 '23 07:07 anhappdev

@anhappdev to create an issue for loadgen

freedomtan avatar Jul 25 '23 05:07 freedomtan