Are these 2 lines should change all the "128" to "this.config.imageSize"?

Open codemee opened this issue 4 years ago • 2 comments

https://github.com/ml5js/ml5-library/blob/441718e65469709481006e98ebc8053c33c778a9/src/UNET/index.js#L116

https://github.com/ml5js/ml5-library/blob/441718e65469709481006e98ebc8053c33c778a9/src/UNET/index.js#L132

Sep 03 '21 06:09 codemee

Yes! You are absolutely correct. Thanks for catching this!

I have opened a project board to find all instances where we are hard-coding values which should not be hard-coded.

I will fix this issue. I'm honestly not sure if we need to be adding an alpha channel at all since tf.browser.toPixels handles that. Maybe since it's a mask we are modifying the values from 1/255.

May 15 '22 19:05 lindapaiste

got it.

May 16 '22 14:05 codemee