mlx icon indicating copy to clipboard operation
mlx copied to clipboard

[Feature Request] Array pickle support

Open dc-dc-dc opened this issue 1 year ago • 2 comments
trafficstars

Add pickle support to array through pybind, docs can be viewed here. This is a pre-req for #300

dc-dc-dc avatar Jan 04 '24 15:01 dc-dc-dc

Thanks for making the issue!

I don't see any reason we shouldn't let an array be pickle-able, so I support adding this.

There may be some thorny issues in terms of managing the state of the array (a lot of it is not currently publicly accessible). If we want to keep it that way, we probably need to do a contiguous copy first.

Also it probably should not be ok to pickle an array used in tracing the graph in a function transform.

awni avatar Jan 04 '24 15:01 awni

Is anyone actively working on this?

awni avatar Jan 08 '24 19:01 awni

If no one is working on it, I can give it a shot

chunyang-wen avatar Jan 11 '24 09:01 chunyang-wen

Sounds great!! I will assign to you!

awni avatar Jan 11 '24 14:01 awni

Anyone working on this?

TristanBilot avatar Feb 09 '24 16:02 TristanBilot

@chunyang-wen any progress?

dc-dc-dc avatar Feb 09 '24 17:02 dc-dc-dc

@dc-dc-dc Sorry. I am on holidays. Will work on it.

chunyang-wen avatar Feb 18 '24 07:02 chunyang-wen

I will remove myself as people are working on it. Sorry for the delay.

chunyang-wen avatar Mar 01 '24 06:03 chunyang-wen