fanciful icon indicating copy to clipboard operation
fanciful copied to clipboard

.itemTooltip() no longer in fanciful?

Open Cryptite opened this issue 9 years ago • 4 comments

Seems this has been entirely removed in 0.4.0-SNAPSHOT with no obvious replacement. Is there some new way to do this now?

Cryptite avatar Aug 31 '16 16:08 Cryptite

It looks like .itemTooltip(), along with .achievementTooltip() and .statisticTooltip(), was removed as part of commit https://github.com/mkremins/fanciful/commit/11a7e606650bf59351b3ebfce2da3af13b7e898b, which was intended to remove Fanciful's dependency on net.minecraft.server APIs and reflection. When I merged that commit I didn't notice that there were public API methods being silently removed with nothing to replace them – thanks for bringing that to my attention.

For the time being, I think you'll have to stick with a previous version of Fanciful if you want to use the various tooltip methods. In the near future, I'll look at the possibility of re-adding support for these methods, ideally in a way which doesn't make us dependent on net.minecraft.server all over again (although I don't know that such a way actually exists at the moment).

mkremins avatar Aug 31 '16 19:08 mkremins

Sure thing, I can stick with 0.3.5, though I was hoping 4.0 might fix some of the issues where when a fanciful message wraps to a new line on the client, it appears to lose formatting.

Cryptite avatar Aug 31 '16 19:08 Cryptite

The line wrapping is a Mojang issue and was fixed in one of the recent releases iirc. Which mc version your client is when seeing the line wrapping issue?

MiniDigger avatar Sep 01 '16 06:09 MiniDigger

I would also appreciate a replacement for this in the latest version as this library was mainly used for this feature alone. Thanks for the great library and keep up the good work!

snowgears avatar Sep 05 '16 02:09 snowgears