k8sviz
k8sviz copied to clipboard
Multi namespace
this modification allows digram generation for many namespace.
@simon-feamzy
Thank you for sending PR. Your idea for supporting multiple namespaces sounds nice. Good work!
I think that you are trying to add below three features in the one PR:
- Supporting multiple namespace
- Supporting CronJob
- Adding Google-cloud-sdk
Could you separate this PR into 3 PRs?
Quick feedback for each feature is as below:
-
Supporting multiple namespace Can we handle below two use cases in a different ways?
- Creating one file per one namespace: Just run the command multiple times for one namespace.
- Creating one merged file for all specified namespace: Just generate one merged file in the go code.
Then, we just need to modify -n option to take namespaces via a string array and loop over the namespaces to add each to a single graph.
-
Supporting CronJob Current codes looks good to me, so it will be able to merge once you separate the PR and add test codes for it.
-
Adding Google-cloud-sdk I didn't get why it is needed. Let's discuss from the use cases.
Opened separated issues below. Let's discuss further there. I think that you can continue using this PR for #28 or create new PR.
-
Supporting multiple namespace #28
-
Supporting CronJob #27
-
Adding Google-cloud-sdk #29
hey, any chance to get this into production? would love it!