k8sviz icon indicating copy to clipboard operation
k8sviz copied to clipboard

Multi namespace

Open simon-ezacae opened this issue 4 years ago • 3 comments

this modification allows digram generation for many namespace.

simon-ezacae avatar Apr 02 '21 10:04 simon-ezacae

@simon-feamzy

Thank you for sending PR. Your idea for supporting multiple namespaces sounds nice. Good work!

I think that you are trying to add below three features in the one PR:

  1. Supporting multiple namespace
  2. Supporting CronJob
  3. Adding Google-cloud-sdk

Could you separate this PR into 3 PRs?

Quick feedback for each feature is as below:

  1. Supporting multiple namespace Can we handle below two use cases in a different ways?

    1. Creating one file per one namespace: Just run the command multiple times for one namespace.
    2. Creating one merged file for all specified namespace: Just generate one merged file in the go code.

    Then, we just need to modify -n option to take namespaces via a string array and loop over the namespaces to add each to a single graph.

  2. Supporting CronJob Current codes looks good to me, so it will be able to merge once you separate the PR and add test codes for it.

  3. Adding Google-cloud-sdk I didn't get why it is needed. Let's discuss from the use cases.

mkimuram avatar Apr 02 '21 16:04 mkimuram

Opened separated issues below. Let's discuss further there. I think that you can continue using this PR for #28 or create new PR.

  1. Supporting multiple namespace #28

  2. Supporting CronJob #27

  3. Adding Google-cloud-sdk #29

mkimuram avatar Apr 02 '21 16:04 mkimuram

hey, any chance to get this into production? would love it!

xeruf avatar Jan 13 '24 05:01 xeruf