Михаил

Results 272 comments of Михаил

@lamdn1409 , look like there is some problems with regressed and deleted `FdwModifyPrivateHasReturning, /* Integer list of attribute numbers retrieved by RETURNING */ ` in `enum FdwModifyPrivateIndex`. Also `SqliteFdwDirectModifyState` can...

> please check the routine PlanDirectModify, Thanks, @lamdn1409 ! I am seeing some unchanged code, not unified with `postgres_fdw`. Will be unified in some hours.

@lamdn1409 , I need a little help near https://github.com/mkgrgis/sqlite_fdw/blob/fc53e3639486d010f8988a371d2e70de5e4f1f8a/sqlite_fdw.c#L5105 I am confused how to integrate `make_tuple_from_result_row` in this place. Could you give some variant?

> @mkgrgis I think result rows should be fetched in sqlite_execute_dml_stmt(). @lamdn1409 , I don't understand this place of data fetching. Now we have inside of `sqlite_execute_dml_stmt()` ```c if (rc...

@lamdn1409 , I have found `get_returning_data` in `postgres_fdw` and trying to adopt this to SQLite C functions.

> You need to handle the case SQLITE_ROW to fetch data rows, then make tuple slot. Please refer to the similar implementation of `IterateForeignScan`. Ok. I think this is main...

> > @mkgrgis You need to handle the case SQLITE_ROW to fetch data rows, then make tuple slot. @lamdn1409 , why there is no `SQLITE_ROW` error in current implementation? `SQLITE_ROW...

> @mkgrgis SQLITE_ROW is not an error code. It indicates that data row is fetched, please check the specification of sqlite_step(). Yes, but discussed code fragment https://github.com/pgspider/sqlite_fdw/pull/107#issuecomment-2562126257 treated all codes...

Thanks, @lamdn1409 ! Now I understand > HINT: SQLite error 'another row available', SQLite result code 100 as result of `sqlite_execute_dml_stmt()` > ./configure --prefix= --enable-cassert --enable-debug CFLAGS="-ggdb -O0 -g3 -fno-omit-frame-pointer"...

@lamdn1409 , I have carefully read `postgres_fdw` and restored 5-6 fragments of `RETURNING` implementation code, but this is still not enough. Now main problem is `TupleDesc` for a table, not...