methanol icon indicating copy to clipboard operation
methanol copied to clipboard

Methanol should implement newWebSocketBuilder

Open gpsfl opened this issue 1 year ago • 3 comments

The default java HttpClient implements the newWebSocketBuilder method, but the Methanol client doesn't. I believe the Methanol client should always forward the method to the underlying client.

Methanol.create().newWebSocketBuilder() // Throws an exception
Methanol.create().underlyingClient().newWebSocketBuilder() // This works

gpsfl avatar Oct 09 '24 09:10 gpsfl

@gpsfl Good catch. I believe there are no fields defined in Methanol that would extend to the websocket, so just forwarding to the underlying client should be fine. Thanks for reporting!

mizosoft avatar Oct 10 '24 09:10 mizosoft

Do you have any plans for a new update with the changes in it?

gpsfl avatar Oct 10 '24 12:10 gpsfl

Yes, will include it in the long-awaited 1.8.0 update. Currently finalizing the last two planned "new" features for this release (Hints API for adapters & Kotlin extensions).

mizosoft avatar Oct 12 '24 06:10 mizosoft