saf icon indicating copy to clipboard operation
saf copied to clipboard

swapped twistlock mapper to results

Open Amndeep7 opened this issue 3 years ago • 2 comments
trafficstars

Signed-off-by: Amndeep Singh Mann [email protected]

Amndeep7 avatar Aug 09 '22 18:08 Amndeep7

Blocked until a release of HDFConverters

Amndeep7 avatar Aug 09 '22 20:08 Amndeep7

Basically a name change and a file naming fix? For my information, in what cases do you name it Mapper and what cases Results? Seems like the only two named Results are Synk and this one.

em-c-rod avatar Aug 29 '22 18:08 em-c-rod

@em-c-rod we use mapper almost all the time. results is if we gotta do some sorta abstraction on top that makes it hard to use mapper directly (ex. the snyk results can return both an execution and an execution array but the base-converter->all mapper classes' toHDF function can only return a single execution). probably could've reworked twistlock to not need it, but it's alright if it does exist.

Amndeep7 avatar Sep 06 '22 22:09 Amndeep7