heimdall2 icon indicating copy to clipboard operation
heimdall2 copied to clipboard

Should look into a replacement lib to handle zip files

Open charleshu-8 opened this issue 2 years ago • 2 comments
trafficstars

          yazl does not seem to be maintained any longer.  we should look into a replacement lib to handle zip files

but also why do we need it at all when we also apparently are using adm-zip which is also a zip library?

admittedly it seems like adm-zip is also probably not being maintained

Originally posted by @Amndeep7 in https://github.com/mitre/heimdall2/pull/3850#discussion_r1306004894

charleshu-8 avatar Aug 25 '23 19:08 charleshu-8

@types/yazl has been removed.

charleshu-8 avatar Aug 25 '23 19:08 charleshu-8

image

this is also a thing that webpack complains about. the dependency isn't included because it's only used in electron builds. there's a way to silence the issue, but like i said earlier i'd rather just swap out this lib entirely if possible.

Amndeep7 avatar Aug 31 '23 04:08 Amndeep7