Azure blob support

[aaronlippold]

trafficstars

• [x] add instructions or help on any needed setup steps on the Azure side for CORS, access, etc.
• [ ] ensure errors are captured and reported at each required and optional field so that users know what they need to fix
• [x] clarify the name of the storage - is Azure Blog the same as an S3 bucket or is this Azure Block storage
• [ ] add unit tests
• [ ] add functional tests
• [ ] add documentation in the help or on the UX of the Nexus

[aaronlippold]

I think we will have to fix this

Aaron Lippold

[email protected]

260-255-4779

twitter/aim/yahoo,etc. 'aaronlippold'

On Wed, Jul 8, 2020 at 12:55 PM Robert Clark [email protected] wrote:

@rbclark commented on this pull request.

In src/components/global/upload_tabs/azure/AuthStepBasic.vue https://github.com/mitre/heimdall-lite/pull/273#discussion_r451682072:

+};

+// We declare the props separately to make props types inferable. +const Props = Vue.extend({

• props: {
• auth_method: Object,
• account_name: String,
• connection_string: String,
• container_name: String,
• account_suffix: String,
• shared_access_signature: String
• } +});

+/** Localstorage keys */ +const local_auth_method = new LocalStorageVal<MultipleSelectObject>(

Instead of creating an object here and then strings for the rest of the account information, could you create an azure_auth localStorageVal and just store all these on that object?

In vue.config.js https://github.com/mitre/heimdall-lite/pull/273#discussion_r451687586:

• config.module

•  .rule("fonts")
  

•  .test(/\.(ttf|otf|eot|woff|woff2)$/)
  

•  .use("url-loader")
  

•  .loader("url-loader")
  

•  .tap(options => {
  

•    options = {
  

•      // limit: 10000,
  

•      name: "./fonts/[name].[ext]",
  

•      publicPath: process.env.NODE_ENV === "production" ? "./" : "/"
  

•    };
  

•    return options;
  

•  })
  

•  .end();
  

As we are working towards heimdall server 2 we need to test this change to make sure it doesn't break anything there.

In vue.config.js https://github.com/mitre/heimdall-lite/pull/273#discussion_r451690078:

@@ -45,6 +45,20 @@ module.exports = { } }, chainWebpack: config => {

• config.module

•  .rule("fonts")
  

•  .test(/\.(ttf|otf|eot|woff|woff2)$/)
  

•  .use("url-loader")
  

•  .loader("url-loader")
  

•  .tap(options => {
  

•    options = {
  

•      // limit: 10000,
  

•      name: "./fonts/[name].[ext]",
  

•      publicPath: process.env.NODE_ENV === "production" ? "./" : "/"
  

Is there a reason this needs to be different only for production? I'm concerned this is something we can't actually validate with our test suite since it only happens in production.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/mitre/heimdall-lite/pull/273#pullrequestreview-444946486, or unsubscribe https://github.com/notifications/unsubscribe-auth/AALK42EYUI6CZXIN6ZB356DR2SQG3ANCNFSM4OP7EPMQ .

[Amndeep7]

Do we need this functionality in heimdall2?